[PATCH] D13135: [ELF2] Add support for -L and -l command line switches

Denis Protivensky via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 25 05:45:16 PDT 2015


denis-protivensky added inline comments.

================
Comment at: ELF/Driver.cpp:78
@@ +77,3 @@
+    // TODO: add support for '-static' option
+    Names.emplace_back((Twine("lib", Path) + ".so").str());
+  }
----------------
Looks like you broke the logic a bit: you must put .so file first to check for it first.

This also means we don't have a test case to cover order of picking DSOs before archive files.
You may do `lld -flavor gnu2 -o %t3 %t.o -L%T -lls` command before creating archive file in the `libsearch.s` test and ensure no errors produced.


http://reviews.llvm.org/D13135





More information about the llvm-commits mailing list