[PATCH] D13135: [ELF2] Add support for -L and -l command line switches

[Igor Kudrin via llvm-commits]

ikudrin marked 5 inline comments as done.

================
Comment at: ELF/Driver.cpp:73
@@ +72,3 @@
+  SmallVector<SmallString<64>, 2> Names;
+  if (Path[0] == ':') {
+    Names.emplace_back(Path.drop_front());
----------------
Thanks! I think the function is much better now.

================
Comment at: ELF/Driver.cpp:96
@@ -65,3 +95,3 @@
 
   // Handle -o
   if (auto *Arg = Args.getLastArg(OPT_output))
----------------
Thanks for pointing it out. The logic was copied from the old ELF driver, but I agree that it's better to follow the behaviour of ld here.

================
Comment at: test/elf2/libsearch.s:9
@@ +8,3 @@
+// RUN: not lld -flavor gnu2 -o %t3 %t.o 2>&1 | FileCheck --check-prefix=UNDEFINED %s
+// UNDEFINED: undefined symbol: _bar
+
----------------
It won't fail with the current approach to symbol resolution.


http://reviews.llvm.org/D13135