[PATCH] D13138: [ELF2] - add support of --noinhibit-exec flag

[Rafael Ávila de Espíndola via llvm-commits]

rafael added a comment.

Just a few fixes.

This should be fine from the writer perspective since we are already handling weak undefined symbols.


================
Comment at: ELF/Writer.cpp:307
@@ +306,3 @@
+
+  std::string Error =
+      "undefined symbol: " +
----------------
grimar wrote:
> Fixed. Sorry for that.
I think you can write this as

std::string Error = "undefined symbol: " + Sym.getName();
if (SymFile)
  Error += " in " ...


================
Comment at: test/elf2/no-inhibit-exec.s:2
@@ +1,3 @@
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t
+# RUN: lld -flavor gnu2 %t --noinhibit-exec -o %t2
+# RUN: not lld -flavor gnu2 %t -o %t2
----------------
Also run llvm-objdump -d to check what we produce.

================
Comment at: test/elf2/no-inhibit-exec.s:11
@@ +10,3 @@
+  call _bar 
+  mov $60, %rax
+  mov $0, %rdi
----------------
You don't need this part


http://reviews.llvm.org/D13138