[PATCH] D13093: [ELF2] - output of all unknown arguments instead of only one

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 24 11:52:56 PDT 2015


ruiu added a comment.

LGTM


================
Comment at: DriverUtils.cpp:66
@@ +65,3 @@
+  if (Unknowns.begin() != Unknowns.end())
+    error(Twine("unknown argument(s) found"));
+
----------------
This Twine() is not needed because error() is overloaded both for StringRef and Twine. I'll make that change and submit.


http://reviews.llvm.org/D13093





More information about the llvm-commits mailing list