[PATCH] D13138: [ELF2] - add support of --noinhibit-exec flag
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 24 09:42:00 PDT 2015
ruiu added inline comments.
Comment at: ELF/Writer.cpp:307-309
@@ +306,5 @@
+ Twine Error =
+ Twine("undefined symbol: ") +
+ (SymFile ? (Sym.getName() + " in " + SymFile->getName()) : Sym.getName());
+ if (Config->NoInhibitExec)
"A Twine is not intended for use directly and should not be stored, its implementation relies on the ability to store pointers to temporary stack objects which may be deallocated at the end of a statement" (http://llvm.org/docs/doxygen/html/classllvm_1_1Twine.html#details)
So make this an std::string rather than a Tiwne.
More information about the llvm-commits