[llvm] r248508 - [ValueTracking] Teach isKnownNonZero a new trick

[James Molloy via llvm-commits]

Author: jamesm
Date: Thu Sep 24 11:06:32 2015
New Revision: 248508

URL: http://llvm.org/viewvc/llvm-project?rev=248508&view=rev
Log:
[ValueTracking] Teach isKnownNonZero a new trick

If the shifter operand is a constant, and all of the bits shifted out
are known to be zero, then if X is known non-zero at least one
non-zero bit must remain.

Added:
    llvm/trunk/test/Analysis/ValueTracking/knownzero-shift.ll
Modified:
    llvm/trunk/lib/Analysis/ValueTracking.cpp

Modified: llvm/trunk/lib/Analysis/ValueTracking.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ValueTracking.cpp?rev=248508&r1=248507&r2=248508&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/ValueTracking.cpp (original)
+++ llvm/trunk/lib/Analysis/ValueTracking.cpp Thu Sep 24 11:06:32 2015
@@ -1827,6 +1827,23 @@ bool isKnownNonZero(Value *V, const Data
     ComputeSignBit(X, XKnownNonNegative, XKnownNegative, DL, Depth, Q);
     if (XKnownNegative)
       return true;
+
+    // If the shifter operand is a constant, and all of the bits shifted
+    // out are known to be zero, and X is known non-zero then at least one
+    // non-zero bit must remain.
+    if (ConstantInt *Shift = dyn_cast<ConstantInt>(Y)) {
+      APInt KnownZero(BitWidth, 0);
+      APInt KnownOne(BitWidth, 0);
+      computeKnownBits(X, KnownZero, KnownOne, DL, Depth, Q);
+      
+      auto ShiftVal = Shift->getLimitedValue(BitWidth - 1);
+      // Is there a known one in the portion not shifted out?
+      if (KnownOne.countLeadingZeros() < BitWidth - ShiftVal)
+        return true;
+      // Are all the bits to be shifted out known zero?
+      if (KnownZero.countTrailingOnes() >= ShiftVal)
+        return isKnownNonZero(X, DL, Depth, Q);
+    }
   }
   // div exact can only produce a zero if the dividend is zero.
   else if (match(V, m_Exact(m_IDiv(m_Value(X), m_Value())))) {

Added: llvm/trunk/test/Analysis/ValueTracking/knownzero-shift.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Analysis/ValueTracking/knownzero-shift.ll?rev=248508&view=auto
==============================================================================
--- llvm/trunk/test/Analysis/ValueTracking/knownzero-shift.ll (added)
+++ llvm/trunk/test/Analysis/ValueTracking/knownzero-shift.ll Thu Sep 24 11:06:32 2015
@@ -0,0 +1,14 @@
+; RUN: opt -instsimplify -S < %s | FileCheck %s
+
+; CHECK-LABEL: @test
+define i1 @test(i8 %p, i8* %pq) {
+  %q = load i8, i8* %pq, !range !0 ; %q is known nonzero; no known bits
+  %1 = or i8 %p, 2                 ; %1[1] = 1
+  %2 = and i8 %1, 254              ; %2[0] = 0, %2[1] = 1
+  %A = lshr i8 %2, 1               ; We should know that %A is nonzero.
+  %x = icmp eq i8 %A, 0
+  ; CHECK: ret i1 false
+  ret i1 %x
+}
+
+!0 = !{ i8 1, i8 5 }