[PATCH] D12913: Fixed debug info emitting for imported entity defined directly in a function scope.
Adrian Prantl via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 24 08:27:10 PDT 2015
aprantl added inline comments.
================
Comment at: lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:336
@@ -335,3 +335,3 @@
- unsigned ChildScopeCount;
+ bool HasNoneScopeChild;
----------------
HasNoneScopeChild is uninitialized here.
================
Comment at: lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:538
@@ -545,3 +537,3 @@
SmallVectorImpl<DIE *> &Children,
- unsigned *ChildScopeCount) {
+ bool *HasNoneScopeChild) {
DIE *ObjectPointer = nullptr;
----------------
This should probably be a reference like Children.
================
Comment at: lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:552
@@ +551,3 @@
+
+ if (HasNoneScopeChild)
+ *HasNoneScopeChild = Children.size() != 0;
----------------
This looks like a use of an undef variable?
Repository:
rL LLVM
http://reviews.llvm.org/D12913
More information about the llvm-commits
mailing list