[PATCH] D13055: [ELF2] Handle -m option

Denis Protivensky via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 24 07:30:21 PDT 2015


Maybe, but that is independent and pretty big, so it should be in another patch.

Agreed.

On 09/24/2015 05:21 PM, Rafael EspĂ­ndola wrote:

On 24 September 2015 at 08:49, Denis Protivensky
<dprotivensky at accesssoftek.com><mailto:dprotivensky at accesssoftek.com> wrote:
> denis-protivensky added a comment.
>
> @rafael, thanks for the patch, but I'd prefer to leave the getElfMachineType method since it allows to simplify the interface of ELFData class and ObjectFile/SharedFile. It removes bunch of methods from the .cpp file as well.

Maybe, but that is independent and pretty big, so it should be in another patch.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150924/3eb012e0/attachment.html>


More information about the llvm-commits mailing list