[patch] Fix pr24486

Maxim Ostapenko via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 24 04:11:53 PDT 2015


Hi, Rafael!

Here is another patch to fix pr24486. Could you please take a look when 
you have a time?

On 08/09/15 20:18, Rafael EspĂ­ndola wrote:
>
> What I think is needed is a more invasive change from Section to
> Fragment. So for example,
>
>   MCStreamer::AssignSection
>
> Would become
>
>   MCStreamer::assignFragment
>
> and there wouldn't be a single dummy fragment. The asm streamer would
> create one for each section it creates.

I thought it would be better to replace MCStreamer::AssignSection with 
MCStreamer::AssignSectionAndFragment, because for some symbols we still 
want to set section explicitly. Does this make sense?

This patch works fine for me and passed make check-all on my 
x86_64-unknown-linux-gnu box as well as simple bootstrap (I've rebuilt 
clang three times by itself).

>
> Cheers,
> Rafael
>

Thanks,
-Maxim
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t4.diff
Type: text/x-patch
Size: 30704 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150924/04a445c6/attachment-0001.bin>


More information about the llvm-commits mailing list