[PATCH][LNT] Avoid creating temporary files in LNT source checkout when running regression tests

[Kristof Beyls via llvm-commits]

Thanks, committed in r248469 and r248470.

 

From: chris.matthews at apple.com [mailto:chris.matthews at apple.com] 
Sent: 23 September 2015 16:45
To: Kristof Beyls
Cc: LLVM Commits; Daniel Dunbar
Subject: Re: [PATCH][LNT] Avoid creating temporary files in LNT source
checkout when running regression tests

 

LGTM! Thank!

 

On Sep 23, 2015, at 8:35 AM, Kristof Beyls <kristof.beyls at arm.com> wrote:

 

Hi,

 

I haven't found much time to work on LNT in the past few months and wanted
to come back to finally
land my binary hash patch, but wanted to do a bit more testing on it. That's
when I realized that there
isn't much documentation on how to develop LNT and particularly on how to
best run the regression
tests. Therefore, I've started writing a very initial developer guide for
LNT, which I've just uploaded for
review at  <http://reviews.llvm.org/D13101> http://reviews.llvm.org/D13101.

 

While writing these guidelines on how to run regression tests while
developing LNT, similar to how everyone
runs regression tests when developing other LLVM sub-projects, I realized
again that running the regression
tests leave temporary files in the source checkout. That has annoyed me
quite a bit in the past, e.g. every
time I needed to run something like "git status" in there. The attached 2
patches should fix this.

 

The first patch makes sure that no .pyc files get generated when running the
regression tests.

The second patch results in temporary files being created in a sub-directory
called "test_run_tmp" of the current directory,
instead of scattered across the test source code directory. This makes it
possible to run the tests out-of-source-tree.
Even when you do run the tests in the source tree, all the temporary files
are in a separate directory, not
scattered across the test source directories.

 

Do these changes look fine to commit?

 

Thanks,

 

Kristof

<0001-Don-t-generate-.pyc-files-when-running-tests.patch><0002-Avoid-leaving
-temporary-files-in-the-source-when-run.patch>

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150924/328bd44e/attachment.html>