[PATCH] D13070: [SimplifyCFG] Speculatively flatten CFG based on profiling metadata

hfinkel@anl.gov via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 17:40:37 PDT 2015

hfinkel added inline comments.

Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:2353
@@ +2352,3 @@
+/// path.  This is code size neutral, but makes it dynamically more expensive
+/// to fail either check.  As such, we only want to do this if both checks are
+/// expected to essentially never fail.
reames wrote:
> hfinkel wrote:
> > either check -> any of the checks
> Happy to make the requested change, but given this applies to a pair of branches, not quite clear why you think the new wording is more clear.
The comment starts with, "If we have a series of tests leading to a frequently executed fallthrough...  we can test all the conditions at once...". You're right, but maybe we should just add something like, "Here, we deal with this one pair of tests at a time." So that it becomes clear that you're now talking about only two checks.


More information about the llvm-commits mailing list