[PATCH] D13115: [CMake] [Darwin] Bug 21562 - Add a CMake equivalent for make/platform/clang_darwin.mk in compiler_rt

[Alexey Samsonov via llvm-commits]

samsonov accepted this revision.
samsonov added a comment.
This revision is now accepted and ready to land.

LGTM, but please address comments below.


================
Comment at: cmake/Modules/CompilerRTDarwinUtils.cmake:176
@@ +175,3 @@
+    ${ARGN})
+    add_custom_command(OUTPUT ${COMPILER_RT_LIBRARY_OUTPUT_DIR}/lib${name}.a
+      COMMAND lipo -output
----------------
Formatting went off here.

================
Comment at: cmake/Modules/CompilerRTDarwinUtils.cmake:185
@@ -163,1 +184,3 @@
+    add_dependencies(${LIB_PARENT_TARGET} ${name})
+    message("darwin_lipo_libs: ${COMPILER_RT_LIBRARY_OUTPUT_DIR}/lib${name}.a")
 endfunction()
----------------
Remove debug output before submitting.

================
Comment at: cmake/Modules/CompilerRTDarwinUtils.cmake:190
@@ -166,1 +189,3 @@
 # OS library is constructed by lipo-ing together single-architecture libraries.
+# Generates builtin libraries for all operating systems specified in ARGN. Each
+# OS library is constructed by lipo-ing together single-architecture libraries.
----------------
Remove duplicated lines


http://reviews.llvm.org/D13115