[PATCH] D13110: New StackMap format

[hfinkel@anl.gov via llvm-commits]

hfinkel added a subscriber: hfinkel.
hfinkel added a comment.

Please add -stackmap-version=2 test cases to all backends that support stackmaps. It would be nice to know that, at least, it does not assert somewhere.


================
Comment at: docs/StackMaps.rst:468
@@ +467,3 @@
+    uint64 : PatchPoint ID
+    uint32 : Instruction Offset
+    uint8  : Call size (bytes)
----------------
Are we now guaranteeing that these are sorted by increasing offset?


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:983
@@ +982,3 @@
+
+    if (SM.hasFrameMap()) {
+      SM.recordFrameMap(SizeExp);
----------------
Don't need { } here.


================
Comment at: lib/CodeGen/StackMaps.cpp:101
@@ +100,3 @@
+bool StackMaps::hasFrameMap() {
+  if (StackMapVersion == 2) {
+    return SM2.hasFrameMap();
----------------
Don't need { } here.



http://reviews.llvm.org/D13110