[PATCH] D13112: [darwin] [builtins] Stop generating cc_kext_ios5 and move iOS architectures out of cc_kext into cc_kext_ios

Chris Bieneman via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 13:10:05 PDT 2015

beanz added inline comments.

Comment at: make/platform/clang_darwin.mk:102
@@ -102,2 +101,3 @@
 # a different code generation strategy). Note: the x86_64 slice is unused but
 # it avoids build problems (see pr14013).
+Configs += cc_kext_ios
bob.wilson wrote:
> This comment needs to be updated.
Will revise.

Comment at: make/platform/clang_darwin.mk:163
@@ -165,4 +162,3 @@
 OSX_DEPLOYMENT_ARGS := -mmacosx-version-min=10.4
-IOS_DEPLOYMENT_ARGS := -mios-version-min=1.0
-IOS6_DEPLOYMENT_ARGS := -mios-version-min=6.0
+IOS_DEPLOYMENT_ARGS := -mios-version-min=6.0
 IOSSIM_DEPLOYMENT_ARGS := -mios-simulator-version-min=1.0
bob.wilson wrote:
> Changing the minimum deployment version from 1 to 6 seems like it ought to be a separate patch.
This actually isn't a functional change. The version 1.0 was only used by the cc_kext_ios5 targets that I'm removing, so I just renamed the IOS6 variable to IOS since the IOS variable became unused.


More information about the llvm-commits mailing list