[lld] r248393 - [elf2] Pass BSSSec to the relocation handling code differently. Don't store it in the symbol.

Michael Spencer via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 10:10:15 PDT 2015


On Wed, Sep 23, 2015 at 10:04 AM, Rafael EspĂ­ndola
<rafael.espindola at gmail.com> wrote:
>> +  // The only type in OutputSections is currently OutputSection.
>> +  for (OutputSectionBase<ELFT::Is64Bits> *OSB : OutputSections)
>> +    static_cast<OutputSection<ELFT> *>(OSB)->setBssSec(BSSSec);
>
> There is already a loop over the output section in the end of this
> function, can't you use it?
>
> Cheers,
> Rafael

No. At that point there are already non OutputSection types in the
vector, so the cast would be wrong, and we don't store type
information (as we don't need it).

- Michael Spencer


More information about the llvm-commits mailing list