[PATCH] D13055: [ELF2] Handle -m option

[Denis Protivensky via llvm-commits]

denis-protivensky added inline comments.

================
Comment at: ELF/Config.h:39
@@ -26,1 +38,3 @@
+  ELFKind ElfKind = ELF64LEKind;
+  uint16_t EMachine = llvm::ELF::EM_X86_64;
 };
----------------
emaste wrote:
> Do we still need an EM_X86_64 default?
It'll be replaced with a reasonable value during linking. Do you have ideas what to put here? EM_NONE?

================
Comment at: test/elf2/emulation.s:1
@@ +1,2 @@
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %tx64
+# RUN: lld -flavor gnu2 -m elf_x86_64 %tx64 -o %t2x64
----------------
emaste wrote:
> It would be nice to have some non-Linux triples as well (e.g. x86_64-unknown-freebsd). @davide or I could add some in a subsequent commit.
Thanks.


http://reviews.llvm.org/D13055