[PATCH] D13063: Faster SimplifyInstructionsInBlock

[Philip Reames via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/one minor comment, but please give it a day or so in case anyone else spots something I've missed.


================
Comment at: lib/Transforms/Utils/Local.cpp:488
@@ -440,1 +487,3 @@
+  // the worklist with the entire function's worth of instructions.
+  for (BasicBlock::iterator BI = BB->begin(), E = --BB->end(); BI != E;) {
     assert(!BI->isTerminator());
----------------
please use std::prev instead of -- here.  Makes it more clear what's going on.


Repository:
  rL LLVM

http://reviews.llvm.org/D13063