[llvm] r248341 - IR: Fix the return value of DICompileUnit::getDWOId.

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 16:34:39 PDT 2015


> On Sep 22, 2015, at 4:28 PM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> Is this testable/missing a test case?

I’m also wondering why this didn’t trigger a compiler warning about a truncated value.

— adrian

> 
> On Tue, Sep 22, 2015 at 4:21 PM, Adrian Prantl via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
> Author: adrian
> Date: Tue Sep 22 18:21:03 2015
> New Revision: 248341
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=248341&view=rev <http://llvm.org/viewvc/llvm-project?rev=248341&view=rev>
> Log:
> IR: Fix the return value of DICompileUnit::getDWOId.
> 
> Modified:
>     llvm/trunk/include/llvm/IR/DebugInfoMetadata.h
> 
> Modified: llvm/trunk/include/llvm/IR/DebugInfoMetadata.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/DebugInfoMetadata.h?rev=248341&r1=248340&r2=248341&view=diff <http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/DebugInfoMetadata.h?rev=248341&r1=248340&r2=248341&view=diff>
> ==============================================================================
> --- llvm/trunk/include/llvm/IR/DebugInfoMetadata.h (original)
> +++ llvm/trunk/include/llvm/IR/DebugInfoMetadata.h Tue Sep 22 18:21:03 2015
> @@ -1026,7 +1026,7 @@ public:
>    DIImportedEntityArray getImportedEntities() const {
>      return cast_or_null<MDTuple>(getRawImportedEntities());
>    }
> -  unsigned getDWOId() const { return DWOId; }
> +  uint64_t getDWOId() const { return DWOId; }
> 
>    MDString *getRawProducer() const { return getOperandAs<MDString>(1); }
>    MDString *getRawFlags() const { return getOperandAs<MDString>(2); }
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150922/beda5553/attachment.html>


More information about the llvm-commits mailing list