[llvm] r248333 - [Unroll] Do not crash trying to propagate a value to vector load.
Michael Zolotukhin via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 22 15:27:13 PDT 2015
Author: mzolotukhin
Date: Tue Sep 22 17:27:12 2015
New Revision: 248333
URL: http://llvm.org/viewvc/llvm-project?rev=248333&view=rev
Log:
[Unroll] Do not crash trying to propagate a value to vector load.
Modified:
llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp
llvm/trunk/test/Transforms/LoopUnroll/full-unroll-crashers.ll
Modified: llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp?rev=248333&r1=248332&r2=248333&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp Tue Sep 22 17:27:12 2015
@@ -423,6 +423,12 @@ private:
if (!CDS)
return false;
+ // We might have a vector load from an array. FIXME: for now we just bail
+ // out in this case, but we should be able to resolve and simplify such
+ // loads.
+ if(!CDS->isElementTypeCompatible(I.getType()))
+ return false;
+
int ElemSize = CDS->getElementType()->getPrimitiveSizeInBits() / 8U;
assert(SimplifiedAddrOp->getValue().getActiveBits() < 64 &&
"Unexpectedly large index value.");
Modified: llvm/trunk/test/Transforms/LoopUnroll/full-unroll-crashers.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/LoopUnroll/full-unroll-crashers.ll?rev=248333&r1=248332&r2=248333&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/LoopUnroll/full-unroll-crashers.ll (original)
+++ llvm/trunk/test/Transforms/LoopUnroll/full-unroll-crashers.ll Tue Sep 22 17:27:12 2015
@@ -81,3 +81,22 @@ for.inc:
for.end:
ret void
}
+
+define <4 x i32> @vec_load() {
+entry:
+ br label %for.body
+
+for.body:
+ %phi = phi i64 [ 0, %entry ], [ %inc, %for.body ]
+ %vec_phi = phi <4 x i32> [ <i32 0, i32 0, i32 0, i32 0>, %entry ], [ %r, %for.body ]
+ %arrayidx = getelementptr inbounds [10 x i32], [10 x i32]* @known_constant, i64 0, i64 %phi
+ %bc = bitcast i32* %arrayidx to <4 x i32>*
+ %x = load <4 x i32>, < 4 x i32>* %bc, align 4
+ %r = add <4 x i32> %x, %vec_phi
+ %inc = add nuw nsw i64 %phi, 1
+ %cmp = icmp ult i64 %inc, 999
+ br i1 %cmp, label %for.body, label %for.exit
+
+for.exit:
+ ret <4 x i32> %r
+}
More information about the llvm-commits
mailing list