[PATCH] D12826: [PM] Wire up optimization levels and default pipeline construction APIs in the PassBuilder.

hfinkel@anl.gov via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 14:42:19 PDT 2015

hfinkel added a subscriber: hfinkel.
hfinkel accepted this revision.
hfinkel added a reviewer: hfinkel.
hfinkel added a comment.
This revision is now accepted and ready to land.

I suppose the idea is that opt -O3 will eventually be wired to be equivalent to -passes='default<O3>'?

Regardless, LGTM.

Comment at: include/llvm/Passes/PassBuilder.h:56
@@ +55,3 @@
+    /// immediately executed as part of testing. As a consequence, where
+    /// possibly, we would like to produce efficient to execute code, but not
+    /// if it significantly slows down compilation or would prevent even basic
probinson wrote:
> possibly -> possible
efficient to execute code -> efficient-to-execute code

Comment at: include/llvm/Passes/PassBuilder.h:113
@@ +112,3 @@
+    /// execution time impact. You should expect this level to produce rather
+    /// slow but very small code.
+    Oz
 slow but very small code ->  slow, but very small, code


More information about the llvm-commits mailing list