[PATCH] D12802: [BasicAA] Non-equal indices in a GEP of a SequentialType don't overlap

[hfinkel@anl.gov via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

There are some comment changes, but otherwise, LGTM.


================
Comment at: lib/Analysis/BasicAliasAnalysis.cpp:768
@@ +767,3 @@
+    // - both GEPs begin indexing from the exact same pointer;
+    // - the last indices in both GEPs are constants, indexing into a sequential
+    //   type (array or pointer);
----------------
We don't seem to know that here, only below, because of how you've modified the C1,C2 check above. Here, we know only that we don't have equal constants.


================
Comment at: lib/Analysis/BasicAliasAnalysis.cpp:780
@@ +779,3 @@
+    
+    // Now we know that the array/pointer that GEP1 indexes into and that
+    // that GEP2 indexes into must either precisely overlap or be disjoint.
----------------
final 'that' -> 'the array/pointer', or similar, to eliminate the 'that that'


Repository:
  rL LLVM

http://reviews.llvm.org/D12802