[PATCH] D13037: dsymutil: Follow references to clang modules and recursively clone the debug info
Frederic Riss via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 22 13:52:37 PDT 2015
friss added a comment.
LGTM once you address one nit:
Comment at: tools/dsymutil/DwarfLinker.cpp:2625
@@ -2590,2 +2624,3 @@
DataExtractor Data = U.getDebugInfoExtractor();
- uint32_t NextOffset = U.getDIEAtIndex(Idx + 1)->getOffset();
+ // Point to the next DIE (usually NULL). If this is a lone
+ // DW_TAG_compile_unit without any children, point to the next unit.
The next DIE isn't usually NULL, but it is usually valid because there's nearly always at least a NULL after it.
More information about the llvm-commits