[PATCH] D13037: dsymutil: Follow references to clang modules and recursively clone the debug info

[Adrian Prantl via llvm-commits]

aprantl added inline comments.

================
Comment at: tools/dsymutil/DwarfLinker.cpp:1145-1146
@@ -1098,1 +1144,4 @@
 
+  void reportWarning(const Twine &Warning, const DWARFUnit *Unit = nullptr,
+                     const DWARFDebugInfoEntryMinimal *DIE = nullptr) const;
+
----------------
friss wrote:
> Can you do that refactoring in a preparatory NFC commit?
248310

================
Comment at: tools/dsymutil/DwarfLinker.cpp:1498-1499
@@ -1442,3 +1497,4 @@
 /// \returns null if resolving fails for any reason.
-const DWARFDebugInfoEntryMinimal *DwarfLinker::resolveDIEReference(
+static const DWARFDebugInfoEntryMinimal *resolveDIEReference(
+    const DwarfLinker &Linker, MutableArrayRef<CompileUnit> Units,
     const DWARFFormValue &RefValue, const DWARFUnit &Unit,
----------------
friss wrote:
> Making that a static helper could be a separate NFC commit too, right?
248311

================
Comment at: tools/dsymutil/dsymutil.h:31
@@ -30,3 +30,3 @@
   bool NoODR;    ///< Do not unique types according to ODR
-
+  std::string PrependPath; //< -oso-prepend-path
   LinkOptions() : Verbose(false), NoOutput(false) {}
----------------
friss wrote:
> Separate NFC patch?
248312


http://reviews.llvm.org/D13037