[PATCH] D13023: [Bug 21683 relative] - Refactor of SimpleDefinedAtom::sortReferences()

Denis Protivensky via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 00:28:02 PDT 2015

denis-protivensky added a subscriber: denis-protivensky.

Comment at: Simple.h:188
@@ -180,2 +187,3 @@
-  static void destroySentinel(lld::SimpleReference*) {}
+  void destroySentinel(lld::SimpleReference *sentinel) {
+	// the same situation as described above in createSentinel()
Next time, please, provide the context.

This is a specialization of `ilist_sentinel_traits` template, and by changing the signature you made the default method play instead of this one. It may be a luck that sorting below worked for you, but it most likely hurt the correctness.



More information about the llvm-commits mailing list