[PATCH] D13041: [llvm-readobj/MachO] Ensure we always have a valid reference to SegmentName

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 21 17:54:39 PDT 2015

davide updated this revision to Diff 35334.
davide added a comment.

I think it's a good idea (we should probably do the same for Section, but we can take care of that in a separate commit).




Index: tools/llvm-readobj/MachODumper.cpp
--- tools/llvm-readobj/MachODumper.cpp
+++ tools/llvm-readobj/MachODumper.cpp
@@ -267,8 +267,8 @@

   struct MachOSegment {
-    StringRef CmdName;
-    StringRef SegName;
+    std::string CmdName;
+    std::string SegName;
     uint64_t cmdsize;
     uint64_t vmaddr;
     uint64_t vmsize;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13041.35334.patch
Type: text/x-patch
Size: 407 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150922/14c9003d/attachment.bin>

More information about the llvm-commits mailing list