[PATCH] D13035: LiveIntervalAnalysis: Avoid multiple connected liveness components

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 21 17:41:10 PDT 2015

qcolombet added a comment.

I guess if it is needed we could have an additional optional parameter (like SmallVectorImpl<unsigned> *) to return the virtual registers created.
Seems like it is not needed for now.

The thing that I do not like is that it seems to me that the handling of multi component is not homogeneous between the non-subregister and the subregister case.

> computeDeadValues() is also used during the initial Liveness computation in which the return value is not checked (because we cannot have deadPhi values at that place).

How hard would it be to account for the returned value?




More information about the llvm-commits mailing list