[PATCH] D13035: LiveIntervalAnalysis: Avoid multiple connected liveness components

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 21 17:28:31 PDT 2015

qcolombet added a comment.

Hi Matthias,

Nice catch!

Right now, this is on the users of shrinkUses to fix the multi component splitting.
The rationale, I think :), is that we want the users to be aware of the any virtual registers that would be created. This is not the case in that patch.

The bottom line is I believe shrinkToUses should return true in those situations and we should fix the users of shrinkToUses, if need to.
Indeed, I, for instance, guess that the register coalescer would already do the right thing if we return true, since it creates new virtual registers, and wouldn’t have to fix it.

What do you think?




More information about the llvm-commits mailing list