[PATCH] D12958: Refactor computeKnownBits alignment handling code

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 21 08:00:47 PDT 2015

reames added inline comments.

Comment at: lib/Analysis/ValueTracking.cpp:1488
@@ -1487,3 @@
-    KnownOne.clearAllBits();
-    return;
-  }
I'm not sure that removing these returns is actually equivalent.  Does computeKnownBits guarantee to preserve any known bits on entry?  (I don't think so?)  If not, then letting these flow down into the generic code may loose information. 


More information about the llvm-commits mailing list