[PATCH] D12698: DAGCombiner: Replace store of FP constant after attemping store merges

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 21 07:21:48 PDT 2015

spatel accepted this revision.
spatel added a reviewer: spatel.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - just a small comment on the test case settings.

Comment at: test/CodeGen/PowerPC/vector-merge-store-fp-constants.ll:1
@@ +1,2 @@
+; RUN: llc -march=ppc64 -mtriple=ppc64-apple-darwin -mattr=+altivec < %s | FileCheck %s
We shouldn't need -mattr=altivec or darwin here; that was excess in the bug report.
Also, for this test and the next one: if you specify the triple, does it change anything to also specify the arch?


More information about the llvm-commits mailing list