[PATCH] D12986: Fix an ARM CodeGen crash on optnone attribute

[silviu.baranga@arm.com via llvm-commits]

sbaranga added a subscriber: sbaranga.

================
Comment at: lib/Target/ARM/ARMTargetMachine.cpp:367
@@ -366,3 +366,3 @@
 
-  if (TM->getTargetTriple().isOSBinFormatELF() && TM->Options.EnableFastISel)
+  if (TM->getTargetTriple().isOSBinFormatELF())
     addPass(createARMGlobalBaseRegPass());
----------------
We need a comment here explaining why we need this even when not using FastISel and why it's ok to do so.

================
Comment at: test/CodeGen/ARM/optnone-pic.ll:9
@@ +8,3 @@
+
+; RUN:  llc < %s -mtriple=armv7-unknown-linux-gnueabi -fast-isel=false \
+; RUN:           -relocation-model=pic
----------------
It would be good to use FileCheck here and check for the function label.


Repository:
  rL LLVM

http://reviews.llvm.org/D12986