[PATCH] D12593: AVX512 : vcmpss/sd implementation

[Elena Demikhovsky via llvm-commits]

delena added inline comments.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:15889
@@ +15888,3 @@
+                                             Subtarget, DAG);
+      return DAG.getNode(ISD::ZERO_EXTEND, dl, MVT::i8, CmpMask);
+    }
----------------
It should be SIGN_EXTEND here.

================
Comment at: lib/Target/X86/X86InstrFragmentsSIMD.td:171
@@ -167,1 +170,3 @@
+def X86cmpms    : SDNode<"X86ISD::FSETCC",     X86CmpMaskCCScalar>;
+def X86cmpmsRnd : SDNode<"X86ISD::FSETCC_RND", X86CmpMaskCCScalarRound>;
 
----------------
Try to use the same FSETCC node with different number of parameters. 

================
Comment at: test/CodeGen/X86/avx512-intrinsics.ll:3989
@@ +3988,3 @@
+
+  %res11 = add i8 %res1, %res2
+  %res12 = add i8 %res3, %res4
----------------
Please use logical ops here "and" / "or". 


Repository:
  rL LLVM

http://reviews.llvm.org/D12593