[PATCH] D12665: [X86][AVX512] extend support in Scalar conversion

[Elena Demikhovsky via llvm-commits]

delena added a comment.

Some minor fixes. You can commit afterwards.


================
Comment at: ../llvm/lib/Target/X86/X86InstrAVX512.td:4597
@@ +4596,3 @@
+// Scalar Conversion with rounding control (RC)
+multiclass avx512_cvt_fp_rc_scalar<bits<8> opc, string OpcodeStr, X86VectorVTInfo _,
+                         X86VectorVTInfo _Src, SDNode OpNodeRnd> {
----------------
You have two pairs of names avx512_cvt_fp_scalar_rc and avx512_cvt_fp_rc_scalar,

avx512_cvt_fp_scalar_sae and avx512_cvt_fp_sae_scalar, please try to rename

================
Comment at: ../llvm/lib/Target/X86/X86IntrinsicsInfo.h:562
@@ -553,1 +561,3 @@
                      ISD::SINT_TO_FP, ISD::SINT_TO_FP),
+  X86_INTRINSIC_DATA(avx512_mask_cvtsd2ss_round, INTR_TYPE_SCALAR_MASK_RM, X86ISD::VFPROUND, 0),
+  X86_INTRINSIC_DATA(avx512_mask_cvtss2sd_round, INTR_TYPE_SCALAR_MASK_RM, X86ISD::VFPEXT, 0),
----------------
The line is too long


http://reviews.llvm.org/D12665