[PATCH] D12337: [Codegen] Ensure stack is properly aligned for call argument initialization

Jeroen Ketema via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 19 06:41:03 PDT 2015


jketema updated this revision to Diff 35166.
jketema added a comment.

Hi Reid,

I've introduced a `getAlignedCallFrameSize` method as suggested and changed call lowering in the X86 target appropriately. I've also introduced a test involving var args, as you suggested.

The X86 target also contains a call to `getNextStackOffset` in the code that determines whether tail call optimization can be performed. I'm not sure if that call should also be changed to `getAlignedCallFrameSize`. I'm also wondering whether `getAlignedCallFrameSize` should be introduced in other targets too.


http://reviews.llvm.org/D12337

Files:
  include/llvm/CodeGen/CallingConvLower.h
  lib/CodeGen/CallingConvLower.cpp
  lib/Target/X86/X86FastISel.cpp
  lib/Target/X86/X86ISelLowering.cpp
  test/CodeGen/X86/win32-spill-xmm.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12337.35166.patch
Type: text/x-patch
Size: 5137 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150919/246a93be/attachment.bin>


More information about the llvm-commits mailing list