[PATCH] D11678: [CodeGen] Fixes *absdiff* intrinsic: LangRef doc/test case improvement and corresponding code change

[Shahid via llvm-commits]

ashahid added a comment.

Hi Hal,

Thanks for your comments, will update the doc accordingly.
See other response inlined.

Regards,
Shahid


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp:747
@@ +746,3 @@
+                                                         *DAG.getContext(), VT),
+                  Sub, DAG.getConstant(0, dl, VT), DAG.getCondCode(ISD::SETGE));
+  SDValue Neg = DAG.getNode(ISD::SUB, dl, VT, DAG.getConstant(0, dl, VT), Sub, &Flags);
----------------
hfinkel wrote:
> Should this be ISD::SETGE for both the signed and unsigned case?
Here ISD::SETGE is for signed case only, unsigned case is handled with early exit.


http://reviews.llvm.org/D11678