[PATCH] D12978: [ELF2] Support relocs for local symbols

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 18 14:22:14 PDT 2015


rafael added inline comments.

================
Comment at: ELF/Writer.cpp:737
@@ +736,3 @@
+      ArrayRef<SectionChunk<ELFT> *> Chunks = File.getChunks();
+      SectionChunk<ELFT> *Section = Chunks[SymIndex];
+      if (!Section)
----------------
You need a section index in here, not a symbol index.

================
Comment at: ELF/Writer.cpp:742
@@ +741,3 @@
+      SymVA = Out->getVA() + Section->getOutputSectionOff() + Sym->st_value;
+    }
+    else {
----------------
git-clang-format


http://reviews.llvm.org/D12978





More information about the llvm-commits mailing list