[PATCH] D12972: [Object/ELF] Ensure preconditions are satisfied.

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 18 13:30:32 PDT 2015


rafael added a comment.

The comment part is fine.

I am not sure how much more useful asserts are than segmentation faults. How about passing in const references? That way ubsan should be able to catch it as soon as an invalid reference is constructed (I think).


Repository:
  rL LLVM

http://reviews.llvm.org/D12972





More information about the llvm-commits mailing list