[PATCH] D12513: Update edge weights properly when merging blocks in if-conversion.

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 18 12:00:35 PDT 2015


hans added inline comments.

================
Comment at: lib/CodeGen/IfConversion.cpp:1689
@@ -1688,3 +1688,3 @@
 
   std::vector<MachineBasicBlock *> Succs(FromBBI.BB->succ_begin(),
                                          FromBBI.BB->succ_end());
----------------
congh wrote:
> hans wrote:
> > I know this is old code, but while you're here, maybe change this to a SmallVector and rename to FromSuccs?
> Done. I found many uses of std::vector in this file. Do we need to change all of them to SmallVector?
You could look at them in a separate patch if you like, but it's probably not very important.

I figured this one would be nice to fix when you're editing the function already.


http://reviews.llvm.org/D12513





More information about the llvm-commits mailing list