[PATCH] D10674: Value profiling - patchset 3

Betul Buyukkurt via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 18 11:25:47 PDT 2015


betulb updated this revision to Diff 35117.
betulb added a comment.

Review comments addressed:

- Removed the ValuesSites[instrprof_value_kind] array and made individual value site vectors for different kinds. Currently only one value site vector is present due to single value kind is valid.
- Added const std::vector<InstrProfValueSiteRecord>& getValueSitesForKind(uint32_t ValueKind) const; and std::vector<InstrProfValueSiteRecord>& getValueSitesForKind(uint32_t ValueKind); methods to retrieve the value site vector reference for a given kind.
- Removed the HashKeyMap member from the indexed reader.


http://reviews.llvm.org/D10674

Files:
  include/llvm/ProfileData/InstrProf.h
  include/llvm/ProfileData/InstrProfReader.h
  include/llvm/ProfileData/InstrProfWriter.h
  lib/ProfileData/InstrProf.cpp
  lib/ProfileData/InstrProfIndexed.h
  lib/ProfileData/InstrProfReader.cpp
  lib/ProfileData/InstrProfWriter.cpp
  tools/llvm-profdata/llvm-profdata.cpp
  unittests/ProfileData/CoverageMappingTest.cpp
  unittests/ProfileData/InstrProfTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10674.35117.patch
Type: text/x-patch
Size: 28474 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150918/b0f68d69/attachment.bin>


More information about the llvm-commits mailing list