[PATCH] D12742: [ARM] Scaling up values in ARMBaseInstrInfo::isProfitableToIfCvt() before they are scaled by a probability to avoid precision issue.

Cong Hou via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 18 11:07:52 PDT 2015


congh added a comment.

In http://reviews.llvm.org/D12742#248570, @rengolin wrote:

> Ok, that makes sense. But just grep won't cut, as if future patches add another one on a different case, we won't notice. Please pipe to FileCheck and use a CHECK line where appropriate. Otherwise, LGTM.


I have changed that test file by using FileCheck. I also disabled the if-conversion so that the original intention of the test remains unchanged. Thank you for the review!


http://reviews.llvm.org/D12742





More information about the llvm-commits mailing list