[PATCH] D12946: Avoid pointer truncation by InstCombine with IntToPtr combining

Mekhanoshin, Stanislav via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 18 10:08:52 PDT 2015


This might be a good solution, but what would zero then mean? That would likely break compatibility with existing spir codes.

Stas

-----Original Message-----
From: Arsenault, Matthew 
Sent: Friday, September 18, 2015 12:58 AM
To: Mekhanoshin, Stanislav; mehdi.amini at apple.com
Cc: david.majnemer at gmail.com; peter_cooper at apple.com; llvm-commits at lists.llvm.org
Subject: Re: [PATCH] D12946: Avoid pointer truncation by InstCombine with IntToPtr combining

arsenm added a comment.

I think for our purposes we care more about the address space of alloca being distinct from the address space of code.

I think adding support for non-0 addrspace alloca would mostly solve this problem and a few other related ones around address space 0 assumptions. The "default" address space code pointer would then just happen to work.


http://reviews.llvm.org/D12946





More information about the llvm-commits mailing list