[PATCH] D12886: Clean up: Refactoring the hardcoded value of 6 for FindAvailableLoadedValue()'s parameter MaxInstsToScan.

[Nick Lewycky via llvm-commits]

nlewycky accepted this revision.
nlewycky added a comment.
This revision is now accepted and ready to land.

LGTM with changes.


================
Comment at: lib/Analysis/Loads.cpp:174
@@ +173,3 @@
+cl::opt<unsigned>
+llvm::DefMaxInstsToScan("max-insts-to-scan", cl::init(6), cl::Hidden,
+  cl::desc("Use this to specify the default maximum number of instructions "
----------------
max-insts-to-scan is too generic, this name applies across the whole of llvm. Maybe "available-load-scan-limit"?

================
Comment at: lib/Analysis/Loads.cpp:175-177
@@ +174,5 @@
+llvm::DefMaxInstsToScan("max-insts-to-scan", cl::init(6), cl::Hidden,
+  cl::desc("Use this to specify the default maximum number of instructions "
+           "to scan backward from a given instruction, when searching for "
+           "its duplicates for -instcombine"));
+
----------------
Mention FindAvailableLoadedValue, don't mention -instcombine.


http://reviews.llvm.org/D12886