[PATCH] D12950: [SCEV] Teach isLoopBackedgeGuardedByCond to exploit trip counts.

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 17 16:03:09 PDT 2015


sanjoy created this revision.
sanjoy added reviewers: atrick, reames, hfinkel, majnemer.
sanjoy added a subscriber: llvm-commits.
sanjoy added dependencies: D12948: [SCEV] Teach SCEV that A < B => (A+1) < (B+1) on no overflow., D12949: [SCEV] Split out a helper function from isImpliedCond; NFC..

If the trip count of a specific backedge is `N`, then we know that
backedge is effectively guarded by the condition `{0,+,1} u< N`.  This
change teaches SCEV to use this condition to prove things in
`isLoopBackedgeGuardedByCond`.

Depends on D12948
Depends on D12949

http://reviews.llvm.org/D12950

Files:
  lib/Analysis/ScalarEvolution.cpp
  test/Transforms/IndVarSimplify/eliminate-comparison.ll

Index: test/Transforms/IndVarSimplify/eliminate-comparison.ll
===================================================================
--- test/Transforms/IndVarSimplify/eliminate-comparison.ll
+++ test/Transforms/IndVarSimplify/eliminate-comparison.ll
@@ -292,5 +292,42 @@
   ret void
 }
 
-!0 = !{i32 0, i32 2147483647}
+define i1 @func_16(i16* %tmp20, i32* %len.addr) {
+; CHECK-LABEL: @func_16(
+entry:
+  %len = load i32, i32* %len.addr, !range !0
+  %tmp18 = icmp eq i32 %len, 0
+  br i1 %tmp18, label %bb2, label %bb0.preheader
+
+bb0.preheader:
+  br label %bb0
+
+bb0:
+; CHECK: bb0:
+  %var_0.in = phi i32 [ %var_0, %bb1 ], [ %len, %bb0.preheader ]
+  %var_1 = phi i32 [ %tmp30, %bb1 ], [ 0, %bb0.preheader ]
+  %var_0 = add nsw i32 %var_0.in, -1
+  %tmp23 = icmp ult i32 %var_1, %len
+; CHECK: br i1 true, label %stay, label %bb2.loopexit
+  br i1 %tmp23, label %stay, label %bb2
+
+stay:
+; CHECK: stay:
+  %tmp25 = getelementptr inbounds i16, i16* %tmp20, i32 %var_1
+  %tmp26 = load i16, i16* %tmp25
+  %tmp29 = icmp eq i16 %tmp26, 0
+  br i1 %tmp29, label %bb1, label %bb2
+
+bb1:
+  %tmp30 = add i32 %var_1, 1
+  %tmp31 = icmp eq i32 %var_0, 0
+  br i1 %tmp31, label %bb3, label %bb0
+
+bb2:
+  ret i1 false
+
+bb3:
+  ret i1 true
+}
 
+!0 = !{i32 0, i32 2147483647}
Index: lib/Analysis/ScalarEvolution.cpp
===================================================================
--- lib/Analysis/ScalarEvolution.cpp
+++ lib/Analysis/ScalarEvolution.cpp
@@ -7005,6 +7005,24 @@
   WalkingBEDominatingConds = true;
   ClearWalkingBEDominatingCondsOnExit ClearOnExit(*this);
 
+  // See if we can exploit an already computed trip count to prove the
+  // predicate.
+  auto BECountIt = BackedgeTakenCounts.find(L);
+  if (BECountIt != BackedgeTakenCounts.end()) {
+    const SCEV *LatchBECount = BECountIt->second.getExact(Latch, this);
+    if (LatchBECount != getCouldNotCompute()) {
+      // We know that Latch branches back to the loop header exactly
+      // LatchBECount times.  This means the backdege condition at Latch is
+      // equivalent to  "{0,+,1} u< LatchBECount".
+      Type *Ty = LatchBECount->getType();
+      const SCEV *LoopCounter =
+          getAddRecExpr(getZero(Ty), getOne(Ty), L, SCEV::FlagAnyWrap);
+      if (isImpliedCond(Pred, LHS, RHS, ICmpInst::ICMP_ULT, LoopCounter,
+                        LatchBECount))
+        return true;
+    }
+  }
+
   // Check conditions due to any @llvm.assume intrinsics.
   for (auto &AssumeVH : AC.assumptions()) {
     if (!AssumeVH)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D12950.35047.patch
Type: text/x-patch
Size: 2511 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150917/6e979a41/attachment.bin>


More information about the llvm-commits mailing list