[PATCH] D12944: [ELF2] Fill up local symbols field correctly

[Davide Italiano via llvm-commits]

On Thu, Sep 17, 2015 at 3:44 PM, Rafael Ávila de Espíndola
<llvm-commits at lists.llvm.org> wrote:
> rafael accepted this revision.
> rafael added a comment.
> This revision is now accepted and ready to land.
>
> LGTM with a nit.
>
>
> ================
> Comment at: ELF/Writer.cpp:764
> @@ +763,3 @@
> +        Out = Section->getOutputSection();
> +        assert(Section != nullptr && Out != nullptr);
> +        ESym->st_shndx = Out->getSectionIndex();
> ----------------
> You have just used Section :-)
>

Meh, there are days where no amount of coffee is enough. Thanks for the review!

>
> http://reviews.llvm.org/D12944
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare