[PATCH] D12941: [ELF2] Use correct symbol table indexes for hash and relocation sections

[Rafael Espíndola via llvm-commits]

Thanks a lot for the patch and bringing the issue to my attention.

There are a few design options to explore in this area:

* We could pass a custom hash to the DenseMap to get the same
iteration order everywhere.
* We could use MapVector.
* We could use a DenseMap<StringRef, SymbolNumber> along with a
std::vector<Symbol*>. Once resolution is done we then clear the map
and sort the vector.

Given that it is not clear which one is better and given that it will
probably not be too difficult to experiment with them, it is probably
better to keep it simple until we can benchmark the code.

I have then switched to using a MapVector in r247911.

Thanks,
Rafael