[PATCH] D12875: Stripping invariant.group metadata in CodeGenPrepare

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 17 09:57:45 PDT 2015


Ok, that helps, but *why* are you removing all the 
invariant.group.barriers?  Is that just an implementation detail?  Or is 
it something fundamental?  In either case, the code in CGP should 
include comments which clarify this.

Philip

On 09/16/2015 08:22 PM, Piotr Padlewski wrote:
> Prazek added a comment.
>
> Because I remove all invariant.group.barrier's in CodeGenPrepare, I also want to remove invariant.group metadata. After removing all invariant.barriers it would be invalid to optimize based on invariant.group metadata, so I don't want to leave trap for future programmer.
>
>
> http://reviews.llvm.org/D12875
>
>
>



More information about the llvm-commits mailing list