[PATCH] D12926: Added MD_invariant_group to LLVMContext

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 17 09:49:24 PDT 2015


LGTM

On 09/17/2015 12:34 AM, Piotr Padlewski via llvm-commits wrote:
> Prazek created this revision.
> Prazek added reviewers: rsmith, nlewycky, majnemer.
> Prazek added a subscriber: llvm-commits.
>
> http://reviews.llvm.org/D12926
>
> Files:
>    include/llvm/IR/LLVMContext.h
>    lib/CodeGen/CodeGenPrepare.cpp
>    lib/IR/LLVMContext.cpp
>
> Index: lib/IR/LLVMContext.cpp
> ===================================================================
> --- lib/IR/LLVMContext.cpp
> +++ lib/IR/LLVMContext.cpp
> @@ -116,6 +116,13 @@
>     assert(UnpredictableID == MD_unpredictable &&
>            "unpredictable kind id drifted");
>     (void)UnpredictableID;
> +
> +  // Create the 'invariant.group' metadata kind.
> +  unsigned InvariantGroupId = getMDKindID("invariant.group");
> +  assert(InvariantGroupId == MD_invariant_group &&
> +         "invariant.group kind id drifted");
> +  (void)InvariantGroupId;
> +
>   }
>   LLVMContext::~LLVMContext() { delete pImpl; }
>   
> Index: lib/CodeGen/CodeGenPrepare.cpp
> ===================================================================
> --- lib/CodeGen/CodeGenPrepare.cpp
> +++ lib/CodeGen/CodeGenPrepare.cpp
> @@ -4836,6 +4836,6 @@
>   }
>   
>   void CodeGenPrepare::stripInvariantGroupMetadata(Instruction &I) {
> -  if (auto *InvariantMD = I.getMetadata("invariant.group"))
> +  if (auto *InvariantMD = I.getMetadata(LLVMContext::MD_invariant_group))
>       I.dropUnknownNonDebugMetadata(InvariantMD->getMetadataID());
>   }
> Index: include/llvm/IR/LLVMContext.h
> ===================================================================
> --- include/llvm/IR/LLVMContext.h
> +++ include/llvm/IR/LLVMContext.h
> @@ -62,7 +62,8 @@
>       MD_dereferenceable = 12, // "dereferenceable"
>       MD_dereferenceable_or_null = 13, // "dereferenceable_or_null"
>       MD_make_implicit = 14, // "make.implicit"
> -    MD_unpredictable = 15 // "unpredictable"
> +    MD_unpredictable = 15, // "unpredictable"
> +    MD_invariant_group = 16 // "invariant.group"
>     };
>   
>     /// getMDKindID - Return a unique non-zero ID for the specified metadata kind.
>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150917/6f91d6a2/attachment.html>


More information about the llvm-commits mailing list