[PATCH] D12680: [InstCombine] Added vector demanded bits support for SSE4A EXTRQ/INSERTQ instructions

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 17 09:12:56 PDT 2015


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

In http://reviews.llvm.org/D12680#247911, @RKSimon wrote:

> Updated - thanks for the comments. If you chaps are happy with the SimplifyDemandedVectorEltsLow helper I can convert other cases to use it in future commits.


Can we hoist the getVectorNumElements() and associated assert into the helper as well? If yes, please do. And certainly now that we have a helper, let's use it to reduce the code bloat wherever possible.

LGTM.


Repository:
  rL LLVM

http://reviews.llvm.org/D12680





More information about the llvm-commits mailing list