[PATCH] D11893: AVX512 : vinserti64x2 implemantation

[Elena Demikhovsky via llvm-commits]

delena added a comment.

Some minor issues to fix. LGTM.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:15964
@@ +15963,3 @@
+        // imm should be adapted to ISD::INSERT_SUBVECTOR behavior
+        unsigned imm = cast<ConstantSDNode>(Src3)->getZExtValue();
+        imm *= Src2.getValueType().getVectorNumElements();
----------------
imm ->Imm

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:15964
@@ +15963,3 @@
+        // imm should be adapted to ISD::INSERT_SUBVECTOR behavior
+        unsigned imm = cast<ConstantSDNode>(Src3)->getZExtValue();
+        imm *= Src2.getValueType().getVectorNumElements();
----------------
delena wrote:
> imm ->Imm
add assert(isa<ConstantSDNode> && ..)


Repository:
  rL LLVM

http://reviews.llvm.org/D11893