[llvm] r246720 - IR: Remove a redundant function. NFC

[Daniel Berlin via llvm-commits]

On Wed, Sep 16, 2015 at 5:14 PM, Justin Bogner <mail at justinbogner.com> wrote:
> Daniel Berlin <dberlin at dberlin.org> writes:
>> I would like to revert this.
>> These functions are in fact, quite different.
>> :)
>>
>> For example, memoryssa uses the assembly annotation writer to print
>> out the on-the-side virtual operands at the beginning of basic blocks
>> so we can use them in tests.
>>
>> See, e.g, http://reviews.llvm.org/D7864's memoryssaprinter.cpp
>>
>> There is no way to do this with "module slot tracker" version of
>> Value.h's print, at all.
>>
>> (Now, it's my fault for not getting memoryssa in early enough for this
>> to be noticed, but i'd still like to revert this commit since it will
>> in fact, be used).
>
> Sure. Personally, I'd just add the function back in the commit that uses
> it, though.

Well, the plan is to add it back in a separate commit *when* I commit
that set of patches, effectively reverting this commit, it's more "is
there any reason not to" :)