[llvm] r247775 - Make the default triple optional by allowing an empty string

Robinson, Paul via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 16 09:45:19 PDT 2015


> Added: llvm/trunk/test/tools/llvm-mc/lit.local.cfg
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-
> mc/lit.local.cfg?rev=247775&view=auto
> ==========================================================================
> ====
> --- llvm/trunk/test/tools/llvm-mc/lit.local.cfg (added)
> +++ llvm/trunk/test/tools/llvm-mc/lit.local.cfg Wed Sep 16 00:34:32 2015
> @@ -0,0 +1,3 @@
> +if not config.target_triple:
> +    config.unsupported = True
> +

The above code means that all tests under test/tools/llvm-mc implicitly have
REQUIRES: default_triple

Therefore explicitly requiring "default_triple" in test/tools/llvm-mc/*
is at best redundant.  I'd prefer that those lines be removed.

That comment applies to all the following changes:

> Modified: llvm/trunk/test/tools/llvm-mc/basic.test
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-
> mc/basic.test?rev=247775&r1=247774&r2=247775&view=diff
> ==========================================================================
> ====
> --- llvm/trunk/test/tools/llvm-mc/basic.test (original)
> +++ llvm/trunk/test/tools/llvm-mc/basic.test Wed Sep 16 00:34:32 2015
> @@ -1,4 +1,4 @@
>  # RUN: not llvm-mc %t.blah -o %t2 2>&1 | FileCheck --check-prefix=ENOENT
> %s
> -# REQUIRES: native
> +# REQUIRES: default_triple
> 
>  # ENOENT: {{.*}}.blah: {{[Nn]}}o such file or directory
> 
> Modified: llvm/trunk/test/tools/llvm-mc/fatal_warnings.test
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-
> mc/fatal_warnings.test?rev=247775&r1=247774&r2=247775&view=diff
> ==========================================================================
> ====
> --- llvm/trunk/test/tools/llvm-mc/fatal_warnings.test (original)
> +++ llvm/trunk/test/tools/llvm-mc/fatal_warnings.test Wed Sep 16 00:34:32
> 2015
> @@ -1,6 +1,6 @@
>  # RUN: not llvm-mc --fatal-warnings %s 2>&1 | FileCheck %s
>  # XFAIL: hexagon
> -# REQUIRES: native
> +# REQUIRES: default_triple
> 
>  # CHECK: error: .warning directive invoked in source file
>  .warning
> 
> Modified: llvm/trunk/test/tools/llvm-mc/line_end_with_space.test
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-
> mc/line_end_with_space.test?rev=247775&r1=247774&r2=247775&view=diff
> ==========================================================================
> ====
> --- llvm/trunk/test/tools/llvm-mc/line_end_with_space.test (original)
> +++ llvm/trunk/test/tools/llvm-mc/line_end_with_space.test Wed Sep 16
> 00:34:32 2015
> @@ -1,2 +1,2 @@
>  RUN: llvm-mc -disassemble %s
> -# REQUIRES: native
> +# REQUIRES: default_triple
> 
> Modified: llvm/trunk/test/tools/llvm-mc/no_warnings.test
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-
> mc/no_warnings.test?rev=247775&r1=247774&r2=247775&view=diff
> ==========================================================================
> ====
> --- llvm/trunk/test/tools/llvm-mc/no_warnings.test (original)
> +++ llvm/trunk/test/tools/llvm-mc/no_warnings.test Wed Sep 16 00:34:32
> 2015
> @@ -1,6 +1,6 @@
>  # RUN: llvm-mc --no-warn %s 2>&1 | FileCheck %s
>  # XFAIL: hexagon
> -# REQUIRES: native
> +# REQUIRES: default_triple
> 
>  # CHECK-NOT: warning:
>  .warning



More information about the llvm-commits mailing list